Skip to content

Conversation

@guillermo-escire
Copy link
Contributor

References

Description

Removes leftover console.log debug statements from the access control components and services, ensuring cleaner production code and improved maintainability.

Instructions for Reviewers

This PR removes three leftover console.log debug statements in the access control form container and bulk access control service.

List of changes in this PR:

  • Removed console.log statements from access-control-form-container.component.ts.
  • Removed console.log statement from bulk-access-control.service.ts.

How to test:

  • Build and run the Angular application.
  • Navigate to the access control form and execute a bulk access control action.
  • Verify that functionality remains unchanged and no console.log output appears in the browser console during normal operation.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug code task 1 APPROVAL pull request only requires a single approval to merge labels Feb 6, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 6, 2026
@tdonohue
Copy link
Member

tdonohue commented Feb 6, 2026

@guillermo-escire : This PR appears to only remove the existing console.log calls and doesn't enforce any new rules. If I understood the ticket correctly, it sounded like @saschaszott and @alanorth were talking about also "banning" console.log statements by using ESLint to enforce the rule.

So, this PR is a good start, but I'm not sure if it's exactly what @saschaszott and @alanorth talked about in #3949.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug code task

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Remove console.log from code and enforce ESLint rule

2 participants